Locomotive Not Appearing in Routes

[meeshu]

In the process of (re)numbering some NS C44-9W locomotives. As part of this process, I like to test/check that the locomotive is working properly by creating a "consist" for the locomotive using TSRE Consist Editor V0.8.004. And then running the locomotive in Explore mode within selected routes using Open Rails stable version 1.5.1.

For locomotive number 8929, the appropriate sound and cabview files were applied and checked against an existing known working sound and cabview files from a BNSF C44-9W locomotive. As well as checking and making sure the engine files were about the same, apart from railroad name and locomotive number.

Appeared to have successfully created a consist for the NS locomotive number 8929 (by itself) via TSRE Consist Editor v0.8.004.

But when trying to select the NS locomotive C44-9W 8929 from the drop down list of consists to run in any route in Explore mode under Open Rails stable 1.5.1, the locomotive consist does NOT appear!?

I've looked at the consist file itself, it seems to be OK. Also looked again at the locomotive engine file (especially for bracket/brace issues including mis-matches and missing), but didn't see anything out of ordinary. Also looked at the corresponding shape file, but all seems to be OK there as well!

Any ideas why the NS locomotive (consist) fails to appear in consist selection for routes?

NS_C44-9W_8929.zip

[kapitaen]

A closing bracket is missing in line 322.

Screen Shot 12-30-24 at 02.09 PM.jpg

PS: The OpenRailLog.txt would also tell you this!
Jan

[meeshu]

Thanks for your comment.

Are you sure about this missing bracket at line 322? Because for the BNSF C44-9W locomotive which has almost exactly the same engine file, the BNSF locomotive is recognized by Open Rails and can be selected for running activities including exploring routes. But for some reason(s) the NS locomotive can't be selected as it doesn't appear on the list of consists.

There is no Open Rails log to check because I can't select the locomotive to begin with in order to run an activity. Since no activity was run, then there is no log generated by Open Rails.

[kapitaen]

Yes, I am sure that a bracket is missing.
To have the loco in the OpenRailsLog.txt you can attach it to a working train consist.

Jan

Oh no, the closing “ is missing in line 320. This makes the closing bracket ineffective.

[meeshu]

Tried putting an open bracket, and then tried putting a closing bracket at line 322. Made no difference. I still can't see nor select the NS C44-9W locomotive.

A bracket may be missing somewhere, but not on line 322.

[eric]

Look to make sure quotes are matched up as well.

In the Consist Editor, are any parameters missing from the lower right?

[meeshu]

Thanks eric (and Jan in his edited post)!

Yes. On line 319 (or as seen on line 320 in the screenshot in Jan's post above), there was a missing close quote on the sound line!

Locomotive now can be selected and run!

[OmenRotcod]

For matching up parentheses and tidying up .eng file or .wag files, I find Etienne Cardot's "MS Tree Editor" [Ref 59898] very useful, because it detects missing parentheses.

David

[eric]

I'll see if I can add some logic in the CE to detect missing brackets and quotes and dump a warning to the logfile.

Sent from my SM-S911U using Tapatalk

[meeshu]

For matching up parentheses and tidying up .eng file or .wag files, I find Etienne Cardot's "MS Tree Editor" [Ref 59898] very useful, because it detects missing parentheses.

David

Thanks for the suggestion.

I downloaded this editor and installed it. Problem is that this version of the editor requires some files from a previous version of this editor which does not seem to be available here. So this editor at present does not work.

[meeshu]

I'll see if I can add some logic in the CE to detect missing brackets and quotes and dump a warning to the logfile.

Sent from my SM-S911U using Tapatalk

Thanks. That could be very useful!

[eric]

This will be available in the next testing version, enabled by "CheckBraces = true" in the Settings.txt file:

[E] Possible Brace Mismatch in :  "e:/msts/trains/trainset/rf_workmen/workmanspacer_1m.wag"
[E] Possible Brace Mismatch in :  "e:/msts/trains/trainset/rf_workmen/workmanspacer_5m.wag"
[E] Possible Quote Mismatch in :  "e:/msts/trains/trainset/rrm_53-6_flats/53-3fcup914899.wag"
[E] Possible Brace Mismatch in :  "e:/msts/trains/trainset/rs dash 9 7200/rs_dash9_7200.eng"
[E] Possible Brace Mismatch in :  "e:/msts/trains/trainset/russelsp_co/russelsp_co.wag"
[I] Compound size height value  "15ft+10in"  truncated to   "15ft" in  "e:/msts/trains/trainset/sd40/sd40.eng"
[I] Compound size length value  "65ft+1m"  truncated to   "65ft" in  "e:/msts/trains/trainset/sd40/sd40.eng"
[E] Possible Brace Mismatch in :  "e:/msts/trains/trainset/sli_atsf_freight/rttx_151818_ld.wag"
[E] Possible Brace Mismatch in :  "e:/msts/trains/consists/oenoloco.con"
​

I've noticed a bunch of files which have extra braces at the end, which isn't a fatal mistake. Some of the quotes are false alarms -- a few descriptions use an escaped quote mark to appear as inches in a measurement.

[peterman]

Howdy,

I just want to be sure about something... is this symbol " what you fellas are referring to as a closing bracket? I've only ever known it as a quotation mark, not a bracket.

regards
Peter

[meeshu]

The " is the quotation mark. Closing bracket/brace/parentheses is ).