OR "Common Inc" Files

**derekmorton** · 11-03-2019, 23:49

Hi Don,

I am running the activity now, I do not get these errors.
I suspect that the error is in "sli_greenriver_freight\openrails\50Ft_COAL_DRGW_1 9699_LD.wag"

Could you post that file for me to look at please?

**lineman** · 11-04-2019, 00:06

sli_greenriver_freight\50Ft_COAL_DRGW_19699_LD.wag this is where my coal wag exists. Note there is no space in the number '19699"

**derekmorton** · 11-04-2019, 00:12

Hi Larry,

You don't have Gerry's include files, so don't have the file that I mentioned.

**Don6218** · 11-04-2019, 08:56

OR Inc File

Originally posted by derekmorton

Hi Don,

I am running the activity now, I do not get these errors.
I suspect that the error is in "sli_greenriver_freight\openrails\50Ft_COAL_DRGW_1 9699_LD.wag"

Could you post that file for me to look at please?

Taken from my Train File: here it is:
OpenRails.zip

**derekmorton** · 11-04-2019, 15:35

Hi Don,

I can't find the problem,
We will have to wait for Gerry to go past.

**crstagg** · 11-04-2019, 16:00

Derek and Don,

You have not looked at the other end. Can Don verify that his Trainset folder has a sub folder named "Common.inc" with a sub folder named "Fleet" with a file named "Standard_Freight_Coupler.inc" ????

AND if those folders and file do exist, WHAT is on line 27?

**R. Steele** · 11-04-2019, 17:47

derekmorton, Hi Don, I can't find the problem, We will have to wait for Gerry to go past.

Originally posted by crstagg

Derek and Don,

You have not looked at the other end. Can Don verify that his Trainset folder has a sub folder named "Common.inc" with a sub folder named "Fleet" with a file named "Standard_Freight_Coupler.inc" ????

AND if those folders and file do exist, WHAT is on line 27?

Just spotted the thread...been recovering from a bike accident during the 1st week of October, today roofers arrived to begin re-roofing the house...so I'm not having much time for trains. Nothing broken, just very bad deep tissue bruising/twisting on my right (typing) side and arm...still hurts, but healing is going as expected.

To the problem: Both Derek and Charles said pretty much everything I could say. Like Derek, I couldn't spot the problem from what Don provided either and as Charles said...probably would be a good idea to work it from the other end. Is the common.inc folder in the proper spot? .... were any mods made to the file path or anywhere else? I have had things like that happen to me, always found the mistake, typos, wrong path, misplaced quotes, could be anything. I'd need some screenshots.

These particular files were tested, both by myself and others, no errors such as Don is seeing were found. I'm using more sub-folders in fleet...one for couplers and another for brakes.

The log is curious...

Information: MaximalPower not found in Diesel Engine Config, set at default value = 3019200

Warning: Found an unexpected EOF, while reading an item started with a double-quote character. in C:\MSTS-1\Microsoft Games\Train Simulator\trains\trainset\SLI_GREENRIVER_FREIGHT\o penrails\..\..\Common.inc\Fleet\Standard_Freight_C oupler.inc:line 27

Warning: Expected depth 0; got depth 2 at end of file (missing ')'?) in C:\MSTS-1\Microsoft Games\Train Simulator\trains\trainset\SLI_GREENRIVER_FREIGHT\o penrails\..\..\Common.inc\Fleet\Standard_Freight_C oupler.inc:line 27

Maximal power is definitely included in all the diesel engine files, without seeing the file the best I can tell is that perhaps a parenthesis is missing somewhere? or a space has somehow slipped in.

**Don6218** · 11-05-2019, 09:05

Originally posted by crstagg

Derek and Don,

You have not looked at the other end. Can Don verify that his Trainset folder has a sub folder named "Common.inc" with a sub folder named "Fleet" with a file named "Standard_Freight_Coupler.inc" ????

AND if those folders and file do exist, WHAT is on line 27?

Yes I do Charles. That is why I am puzzled that this is happening. I even re-downloaded the files to be sure it was not corrupt.
Common Inc Files.jpg

**Don6218** · 11-05-2019, 09:12

Here is the file in question in ConText:
Common Inc Files Coupler.jpg

**R. Steele** · 11-05-2019, 10:17

Originally posted by Don6218

Here is the file in question in ConText:
[ATTACH=CONFIG]77867[/ATTACH]

That would not cause a problem because it is in a comment line. It sure would cause a problem if incorrect quote marks were found in a working part of the file.
I just checked the upload in my archives and also downloaded the Green River conversion kit from the FL and that error in the comment line does not appear...so the big question is: how did it get there? and are there any other like it in the working files?

One thing to check...look at the default MSTS wagon -- 50Ft_COAL_DRGW_19699_LD.wag -- in the Green River freight folder ( NOT the OR wagon of the same name in the OpenRails folder ) and see if there are any errors in it. If there is, OR will cough up a warning in the log when it reads the data in the OpenRails folder.
The warning is misleading in that it leads one to believe that the error is to be found in the wagon (of the same name) in the OpenRails folder.

**crstagg** · 11-05-2019, 10:51

The error in the log file refers to line 27 in that file. You posted a picture of that file using ConText without line numbers turned on (On Context Menu choose Environment Options > Editor Tab > check Line Numbers middle of list). I tried to count the lines from your picture and it appears line 27 is the closing Paren for the Front Coupling section.

Again quoting log file:

Warning: Found an unexpected EOF, while reading an item started with a double-quote character. in C:\MSTS-1\Microsoft Games\Train Simulator\trains\trainset\SLI_GREENRIVER_FREIGHT\o penrails\..\..\Common.inc\Fleet\Standard_Freight_C oupler.inc:line 27

Warning: Expected depth 0; got depth 2 at end of file (missing ')'?) in C:\MSTS-1\Microsoft Games\Train Simulator\trains\trainset\SLI_GREENRIVER_FREIGHT\o penrails\..\..\Common.inc\Fleet\Standard_Freight_C oupler.inc:line 27

Note the first warning? "Found an unexpected EOF" Appears ORTS was expecting more data or a closing ")"

Could investigate more if you would post the actual file so that it could be looked at with Special characters turned on and/or converted to Hex to look for errors.

**crstagg** · 11-05-2019, 10:55

Question for Gerry. Why is the entire text in the file indented?

What is the original download for this INC file?

**crstagg** · 11-05-2019, 11:07

Gerry,
Note the second Comment line has "..\\..\\ then closes the quote with a ' not a "

Could that be causing ORTS to log a Warning?

NOTE: I just downloaded Open Rails Conversion Kit For DRGW Green River Name: drgwgreenriver_orkit.zip
which contains \\Common.inc\\Fleet\\Standard_Freight_Coupler.inc
Opened file in Context and found second comment to have:
Comment ( include ( "..\\..\\Common.inc\\Fleet\\Standard_Freight_Coupl er.inc" ) )
NOT
Comment ( include ( "..\\..\\Common.inc\\Fleet\\Standard_Freight_Coupl er.inc' ) )
as shown in picture of this file uploaded by Don.

Not having the ORIGINAL WAG or SLI Green River I cannot test to see if the "----' vice "----" cause the Warnings.

**crstagg** · 11-05-2019, 12:32

Just guessing, but it appears that the ORTS Parser was looking for the closing Quote, read to the EOF and not having a Warning message for closing of a Quote logged a Warning for closing of a Paren. So the OpenRails coupler data was not read and the coupler data from the original WAG file was used.

BTW In post #14 the line I quoted from does not have a space between the l and the e in coupler. Don't know where that came from. T-S frequently adds carriage returns where there is none when one pastes maybe that is where it came from.