BrakesEngineControllers - Line in Eng File - A Question?

[R. Steele]

Is the following line incorrectly written, causing dynamics not to be seen in OR?

BrakesEngineControllers( "Independent, Train,Dynamic" )

or should there be a space between ...Train, Dynamic" ) ?

Having a little trouble with some dynamic brakes and thought this might be it. Did a search and found quite a few eng files with the space missing.

[baldwin]

The only thing I can suggest is to put the space in and see if it solves the dynamics problem. If it makes no difference, then the problem lies elsewhere in the file.

[EricF]

I'm pretty sure it needs a space after each comma, as in " ( "Independent, Train, Dynamic" ) ".

Fix that, and if it still fails, try hunting in the related sections for other problems. The big two I've found are comments that OR considers misplaced, usually a " #Insert Comment Here ) " that causes everything including the ")" to be ignored -- which leaves an open parenthesis -- and in at least one case, a blank line in a block that OR expected to be filled-in.

For the bad comments, I just cut out the comment text and paste it below the affected line and those sections work OK.

Just removing the blank line in a block that had one causing an error seems to have worked. Blank lines are fine between blocks of related statements, but it seems best that you don't leave a blank line in the middle of a group of statements -- even if all the parenthesis match up. On the other hand, a comment or "Skip + text" is fine.

[R. Steele]

The first thing I did was to add the space, since OR has been developed to read files accurately.
I was wondering what the correct format was....since there are some strange curveballs found in the MSTS files.

Thanks Eric for the tip concerning the comment lines and OR. I have found that, although I have been deleting them or adding an annotation file to the respective eng of wag. I like you way of correcting it, I think I'll try that.

Thanks to both posters.

[Navcom]

This line correct must look like this: BrakesEngineControllers ( "Independent, Train, Dynamic" ) but if in EngineControllers section not have data for dynamic brakes then dynamic brakes not work. This section must look like this:

EngineControllers (
Throttle ( 0 1 0.125 0
NumNotches ( 9
Notch ( 0 0 Dummy )
Notch ( 0.125 0 Dummy )
Notch ( 0.25 0 Dummy )
Notch ( 0.375 0 Dummy )
Notch ( 0.5 0 Dummy )
Notch ( 0.625 0 Dummy )
Notch ( 0.75 0 Dummy )
Notch ( 0.875 0 Dummy )
Notch ( 1 0 Dummy )
)
)
Brake_Engine ( 0 1 0.0125 0
NumNotches ( 1
Notch ( 0 1 Dummy )
)
)
Brake_Train ( 0 1 0.0125 0.75
NumNotches ( 5
Notch ( 0 0 TrainBrakesControllerReleaseStart )
Notch ( 0.3 1 TrainBrakesControllerGraduatedSelfLapLimitedHoldin gStart )
Notch ( 0.85 0 TrainBrakesControllerSuppressionStart )
Notch ( 0.9 0 TrainBrakesControllerContinuousServiceStart )
Notch ( 0.95 0 TrainBrakesControllerEmergencyStart )
)
)
Brake_Dynamic ( 0 1 0.1111 0
NumNotches ( 10
Notch ( 0 0 Dummy )
Notch ( 0.1111 0 Dummy )
Notch ( 0.2222 0 Dummy )
Notch ( 0.3333 0 Dummy )
Notch ( 0.4444 0 Dummy )
Notch ( 0.5555 0 Dummy )
Notch ( 0.6666 0 Dummy )
Notch ( 0.7777 0 Dummy )
Notch ( 0.8888 0 Dummy )
Notch ( 0.9999 0 Dummy )
)
)
Combined_Control ( 0 1 0.5 0.5 throttle dynamic )
DirControl ( -1 0 1 1 )
BellToggle ( 0 1 0 )
AWS ( 0 1 0 )
Sanding ( 0 1 0 )
Horn ( 0 1 0 )
Wipers ( 0 1 0 )
EmergencyStopToggle ( 0 1 0 )
Vigilance ( 0 1 0 )
Headlights ( 0 0.25 1 0 )
BailOffButton ( 0 1 0 )
)
NOTE: This section is from Dash 9 ENG file.

[Armchair_Engo]

In my tests, the spaces in BrakesEngineControllers ( "Independent, Train, Dynamic" ) are not required. This is as I expected since the parameters are separated by the commas, not the whitespace.
BrakesEngineControllers("Independent,Train,Dynamic ") should work exactly the same.
There are plenty of examples where delimiting is done with whitespace, but this is not one of them.

Even the double-quotes are not necessary, so that BrakesEngineControllers(Independent,Train,Dynamic) shoud also work.