Monon v2 15 and 16

[drjayyy]

Monon worked in previous releases of ORTS but not 1726

Open Rails is starting...
Argument 0 = -start
Argument 1 = C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\PATHS\ER Bloomington North.pat
Argument 2 = C:\Program Files (x86)\Microsoft Games\Train Simulator\TRAINS\CONSISTS\1 Dash + 8 Cement.con
Argument 3 = 12:00
Argument 4 = 1
Argument 5 = 0
Version = X.1726
Build = 0.0.4989.35349 (2013-08-29 19:38:18Z)
Logfile = C:\Users\jay\Desktop\OpenRailsLog.txt
------------ ---------- ------------ ---------- ------------ ---------- --------
AdhesionMovingAverageFilterSize = 10
Alerter = False
AvatarURL = http://openrails.org/images/support-logos.jpg
BrakePipeChargingRate = 21
BreakCouplers = False
Cab2DStretch = (registry) 25
CarVibratingLevel = (registry) 1
DataLogger = False
DataLoggerSeparator = comma
DataLogMisc = False
DataLogPerformance = True
DataLogPhysics = False
DataLogSpeedUnits = route
DataLogStart = False
DistantMountains = (registry) True
DistantMountainsLoweringValue = (registry) 6
DistantMountainsViewingTiles = (registry) 40
DoubleWire = (registry) True
DynamicShadows = (registry) True
FullScreen = False
GraduatedRelease = (registry) True
LoadingDelay = 0
LODViewingExtention = (registry) True
Logging = True
LoggingFilename = OpenRailsLog.txt
LoggingPath = C:\Users\jay\Desktop
Menu_Selection = (registry) C:\Program Files (x86)\Microsoft Games\Train Simulator, C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON,
MSTSBINSound = (registry) True
Multiplayer = False
Multiplayer_Host = 127.0.0.1
Multiplayer_Port = 30000
Multiplayer_UpdateInterval = 10
Multiplayer_User = jay
MultiplayerClient = False
MultiplayerServer = False
PerformanceTuner = False
PerformanceTunerTarget = (registry) 75
Precipitation = (registry) True
Profiling = False
ProfilingFrameCount = 0
ProfilingTime = 0
ReplayPauseBeforeEnd = True
ReplayPauseBeforeEndS = 0
ScreenshotPath = C:\Users\jay\Pictures\Open Rails
ShaderModel = 0
ShadowAllShapes = False
ShadowMapBlur = True
ShadowMapCount = 4
ShadowMapDistance = 0
ShadowMapResolution = 1024
ShowAvatar = False
ShowErrorDialogs = True
SoundDetailLevel = 5
SoundVolumePercent = 100
SuperElevationGauge = 1435
SuperElevationMinLen = (registry) 55
SuppressConfirmations = (registry) True
TrainLights = (registry) True
UseAdvancedAdhesion = True
UseSuperElevation = (registry) 2
VerticalSync = False
ViewDispatcher = (registry) True
ViewingDistance = (registry) 1700
ViewingFOV = 45
WindowGlass = (registry) True
WindowPosition_Activity = (registry) 0, 60
WindowPosition_Compass = (registry) 0, 0
WindowPosition_ComposeMessage = (registry) 0, 50
WindowPosition_DriverAid = 100, 100
WindowPosition_Help = (registry) 0, 55
WindowPosition_NextStation = (registry) 0, 93
WindowPosition_Quit = (registry) 0, 51
WindowPosition_Switch = 0, 50
WindowPosition_TrackMonitor = (registry) 100, 50
WindowPosition_TrainOperations = (registry) 0, 49
WindowSize = (registry) 1920x1080
Wire = (registry) True
WorldObjectDensity = 10
------------ ---------- ------------ ---------- ------------ ---------- --------
Mode = Explore
Path = C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\PATHS\ER Bloomington North.pat
Consist = C:\Program Files (x86)\Microsoft Games\Train Simulator\TRAINS\CONSISTS\1 Dash + 8 Cement.con
Time = 12:00
Season = 1
Weather = 0
------------ ---------- ------------ ---------- ------------ ---------- --------
Loading TRK TDB

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 22923

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 24663

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 30061

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 60224

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 60532

Warning: Track node pin has invalid link 0 in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\MONON-2.tdb:line 71857

SIGCFG

Warning: ) Not Found - instead found "SignalFlags" in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\sigcfg.dat:line 1420

Warning: Some of this STF file was not parsed. in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\sigcfg.dat:line 1420

Error: MSTS.STFException: ) Not Found - instead found "SignalFlags" in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\sigcfg.dat:line 1420

at MSTS.STFReader.MustMatchFromBlock(String target)
at MSTS.STFReader.ReadFloatBlock(UNITS validUnits, Nullable`1 defaultValue)
at MSTS.SignalAspect.<>c__DisplayClass6.<.ctor>b__0()
at MSTS.STFReader.ParseBlock(TokenProcessor[] processors)
at MSTS.SignalAspect..ctor(STFReader stf)
at MSTS.SignalType.<>c__DisplayClass1d.<ReadAspects>b __1b()
at MSTS.STFReader.ParseBlock(TokenProcessor[] processors)
at MSTS.SignalType.ReadAspects(STFReader stf)
at MSTS.SignalType.<>c__DisplayClass11.<.ctor>b__4()
at MSTS.STFReader.ParseBlock(TokenProcessor[] processors)
at MSTS.SignalType..ctor(STFReader stf)
at MSTS.SIGCFGFile.<>c__DisplayClass13.<ReadSignalTyp es>b__12()
at MSTS.STFReader.ParseBlock(TokenProcessor[] processors)
at MSTS.SIGCFGFile.ReadSignalTypes(STFReader stf)
at MSTS.SIGCFGFile.<>c__DisplayClassa.<.ctor>b__2()
at MSTS.STFReader.ParseFile(TokenProcessor[] processors)
at MSTS.SIGCFGFile..ctor(String filenamewithpath)
at ORTS.Simulator..ctor(UserSettings settings, String activityPath)
at ORTS.Program.InitSimulator(UserSettings settings, String[] args, String mode)
at ORTS.Program.InitSimulator(UserSettings settings, String[] args)
at ORTS.Program.Start(UserSettings settings, String[] args)
at ORTS.Program.<>c__DisplayClass6.<Main>b__3()
at ORTS.Program.Main(String[] args)

[releismetrain]

Hi,
Yes Open rails latest OR_X spits the Dummy with the Monon Route old and new Version.

Regards Geoff

[baldwin]

Strange. That error report shows line 1420 as SignalFlags, but that line in my sigcfg.dat file is Position. I get that error for line 1472 which really is SignalFlags.

[rrroberttt]

I filed an bug report on this maybe two weeks ago. This particular bug seems to only happen on the Monon Route. It started after x1719. All other routes that I have tried, run ok.

[cjakeman]

I filed an bug report on this maybe two weeks ago.

Sorry for the delay. I didn't realise that report was related to my recent work on the parser.

I'll take a look tonight.

Chris
OR Dev

[slipperman]

Hi,
I don't think this is an Open Rails bug!

First of all, the OP's log is for the old Monon route - in Monon-2, I believe the line to be 1472, as reported by Baldwin.

May I say that I haven't run this route in MSTS or OR, having just downloaded it and checked the sigcfg.dat file, so I may be wrong.

Starting at line 1472 is this segment :

SignalAspects ( 3
SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 SignalFlags ( ASAP ) ) )
SignalAspect ( APPROACH_2 "Approach" SpeedMPH ( 30 SignalFlags ( ASAP ) ) )
SignalAspect ( CLEAR_2 "Clear" )
)

Looking for a similar line, earlier in the file, I find, starting at line 152 :

SignalAspects ( 4
SignalAspect ( STOP_AND_PROCEED "Red" SpeedMPH ( 10 ) )
SignalAspect ( APPROACH_1 "Yellow" SpeedMPH ( 30 ) )
SignalAspect ( APPROACH_2 "Flashing Yellow" SpeedMPH ( 45 ) SignalFlags ( ASAP ) )
SignalAspect ( CLEAR_2 "Green" )
)

I think the difference is plain to see! In the line 152 section, the SpeedMPH value is followed by a close bracket, before the SignalFlags parameter, whereas in the line 1472 section, the speed value is followed by SignalFlags, without the bracket (it's put at the end of the line).

There are several similar entries in the file, after line 1472.

Hope this has been of some help!

Cheers,
Ged

[Rick-MONON]

So are you saying the 2 extra )) should be removed in the file?

[gkhager]

I believe that he is saying that one of the three ' ) ' at the end of the line needs to be moved to after the speed ' ( 30 ' and before ' SignalFlags '. Also, there should be one after the ' "Clear" ' on the last line.

[slipperman]

Hi Rick,

So are you saying the 2 extra )) should be removed in the file?

NO! Comparing the line 1472 section with the line 152 section, I feel that, for example, the second line of the former should be :
SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 ) SignalFlags ( ASAP ) )

This makes it into the same format as the 4th line in the line 152 section.

I'd like to emphasise that I know nothing about sigcfg files, but I do know about files and parameters in general, and this seemed to stand out, to me, as being incorrect, particularly as the line 152 section was not reported as being in error. The part of the log file which pointed this out is this (line 1420 probably because it's the old Monon route) :

Error: MSTS.STFException: ) Not Found - instead found "SignalFlags" in C:\Program Files (x86)\Microsoft Games\Train Simulator\ROUTES\MONON\sigcfg.dat:line 1420

Cheers,
Ged

EDIT : Thanks gkhager, it was poor copy/pasting on my part; there is a close bracket after the "CLEAR" - I have inserted it!

[baldwin]

I see what you mean Ged To match the segment that does not throw an error
SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 SignalFlags ( ASAP ) ) ) has to be changed to read
SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 )SignalFlags ( ASAP ) )

[slipperman]

Hi Baldwin,
Yes, but I think there should be a space between the close bracket and the word SignalFlags.

Sometimes these spaces are important and other times, they don't seem to be, which makes it difficult to know what is, and isn't, valid !! When I create or amend eng / wag files, I tend to put spaces around brackets and I don't see the sigcfg.dat file as being much different to them.

Cheers,
Ged

[Rick-MONON]

Oh My Gosh,, way too busy building version 17 to deal with that now or soon.
Anyone wanna try the corrections. This might explain the stuck trains when building meets at some places..........

[Rick-MONON]

Well, if you change them from ) ) )to ) ), u get a load error in msts.........


Try removing the original "Monon" route and try again......

The SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 SignalFlags ( ASAP ) ) ) is correct!!!!!!!!!!!!!!!!!

open and close brackets

( ASAP )
( 30 SignalFlags ( ASAP ) )
SignalAspect ( APPROACH_3 "Caution" SpeedMPH ( 30 SignalFlags ( ASAP ) ) )

[baldwin]

I am going to make the changes where needed and go try it in MSTS later on. I think Ged is correct in his analysis of the file. Don't forget that MSTS has no proper error checking and that within OR this specific error is not flagged until that particular line arrangement is met.

While it may look correct with matching opening and closing brackets, merely removing the last one will generate an error in MSTS because then there is no corresponding opening bracket in the line.

[slipperman]

Hi Rick,
As Baldwin has pointed out, you can't just remove one of the close brackets!!
I didn't remove a bracket - I MOVED it!
Please have a look at a) the line which OR accepted and b) the one it reported as in error. Then look carefully at the OR error message - it's all there.

If you think that OR and I are wrong, so be it. I did say that I'm not an expert, but, like OR, I try to be logical

Cheers,
Ged